Misc fixes #24
Merged
Misc fixes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is shared logic in the GET and HEAD codepaths surrounding stat()ing the requested file, and sanity checking that the request is indeed valid. This commit de-duplicates this code into a single path.
There's no particular reason why uploaded files should have the executable bit set, and doing so probably has vague security implications.
ThomasLeister
approved these changes
Dec 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits are some fixes I've applied locally. Uploaded files are by default created with the executable bit set, so I've changed the code to avoid doing this, and there's common logic in the GET and HEAD request handling, which I've merged into a single path.